Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect context.projectMetadata.hasRouter and send to the index #1112

Merged
merged 9 commits into from
Nov 7, 2024
Merged

Detect context.projectMetadata.hasRouter and send to the index #1112

merged 9 commits into from
Nov 7, 2024

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 30, 2024 •
edited by chromatic-ci-bot
Loading

This PR is blocked on an index change (to come).

To QA:

  • Create a routing based project (e.g. SB Next Sandbox)
  • Run a build, check it sets hasRouter=true
  • Create a non-routed project (e.g. react-vite Sandbox)
  • Run a build, check it sets hasRouter=false

Use this review app: https://github.com/chromaui/chromatic/pull/9061

📦 Published PR as canary version: 11.19.0--canary.1112.11732911724.0

✨ Test out this PR locally via:

npm install chromatic@11.19.0--canary.1112.11732911724.0
# or 
yarn add chromatic@11.19.0--canary.1112.11732911724.0

@tmeasday tmeasday requested a review from codykaup October 30, 2024 03:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

📦 Package Size: 5380 KB

@tmeasday tmeasday added enhancement Classification: New feature or request release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Oct 30, 2024
@tmeasday tmeasday marked this pull request as draft October 30, 2024 04:18
@tmeasday
Copy link
Member Author

I plan to add some other fields to projectMetadata. Would you prefer one PR or many @codykaup ?

@codykaup
Copy link
Contributor

I plan to add some other fields to projectMetadata. Would you prefer one PR or many @codykaup ?

Totally your call @tmeasday ! I usually base it on the size and concept of the change. I think since you're adding a bunch of metadata and there's a timezone difference, I'm cool with a single PR for it!

@codacy-production Codacy Production
Copy link

codacy-production bot commented Nov 1, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 89e6d251 ✅ 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (89e6d25) Report Missing Report Missing Report Missing
Head commit (0c1a9b2) 7190 4913 68.33%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1112) 66 66 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@tmeasday tmeasday marked this pull request as ready for review November 1, 2024 06:54
@tmeasday tmeasday force-pushed the tom/cap-2327-track-hasrouter-and-haspagecomponents-on-build-events branch from e810edd to b338a3f Compare November 1, 2024 06:54
codykaup
codykaup reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@codykaup codykaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good other than the placement of setting ctx.projectMetadata!

node-src/tasks/gitInfo.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday requested a review from codykaup November 7, 2024 02:10
@tmeasday tmeasday added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 7d7e8c3 Nov 7, 2024
21 checks passed
@tmeasday tmeasday deleted the tom/cap-2327-track-hasrouter-and-haspagecomponents-on-build-events branch November 7, 2024 23:10
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.18.0 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Nov 7, 2024
@tmeasday tmeasday mentioned this pull request Nov 12, 2024
Merged
@tmeasday tmeasday mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codykaup codykaup codykaup approved these changes

Assignees
No one assigned
Labels
enhancement Classification: New feature or request minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmeasday @codykaup @chromatic-ci-bot